Repository navigation
fix(rest): regenerate the schema inventory inside the refresh land step - #1378
Merged
Merged
Conversation
The schema-attribution inventory (conformance/inventory/schema-inventory.json) is derived from the fragment bytes and its hermetic drift gate requires the committed file to equal a byte-identical regeneration. The refresh workflow landed fragment deltas without regenerating the inventory, so every fragment-carrying refresh dispatch failed the change-scoped test union and the refresh PR never opened (runs 44016598070 on 11-17 and 44457762110 on 11-19, both blocked on the upstream writeCondition addition to insert/upsert). The land step now spawns the same generator command the gate runs, inside the atomic commit, and the git add covers the inventory path. Local replay with the real retained artifact fragment reproduces the drift failure before the change and a green gate after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The schema-attribution inventory (
conformance/inventory/schema-inventory.json) is derived from the fragment bytes and its hermetic drift gate (inventory.test.mjs, selected by the change-scoped test union on any fragment change) requires the committed file to equal a byte-identical regeneration.The refresh workflow landed fragment deltas, titles, ledger drafts, the lifecycle-evidence inventory, and the lock pin bump — but never regenerated
schema-inventory.json, and itsgit addonly coveredrest/meta. Every fragment-carrying refresh dispatch therefore failed the change-scoped union and the refresh PR never opened:writeConditionrequest field toPOST /v2/vectordb/entities/insertandupsert; the applier staged it into04-vector-operations-v2.json, the inventory trailed, the gate failed, PR step skippedChange
generate-inventory.mjs— the very command the drift gate runs — into the atomic commit whenever fragment bytes moved (a zero-diff regeneration is impossible: the inventory pins a sha256 per fragment).git addextends torest/conformance/inventory/schema-inventory.json(it lives outsiderest/meta).rest-upstream-pipelinereason updated to match.Verification
Local replay with the real retained artifact fragment from run 44457762110 (the staged
writeConditionfragment):not ok 1 - schema-inventory regenerates byte-identical (drift gate)(CI failure reproduced)# pass 2 / # fail 0; inventory diff carries exactly the 2writeConditionentries; simulation files restored afterwardSelector union for
.github/workflows/rest-upstream-refresh.yml+schema-inventory.json(all green locally):pnpm test:rest-upstream,pnpm test:rest-publication-contract,pnpm test:workflow-policy,pnpm test:workflow-matrixnode --test: drift-watchdog, dispatch-refresh, dispatch-linkage-workflow, decide-batches, branch-plan, translate-additions, refresh-lifecycle-inventory, assert-track-projection, webcontent-sync-drift, archive, inventory, cases-integrity, diff, case-runner, goldens-integrity, schema-verify, deploy contracts ×3actionlinton the changed workflow,git diff --checkCI is authoritative for the shared-docs gate (known local load flakes); the union above contains no shared-docs gate.